[PATCH] D68383: [llvm-readelf/llvm-objdump] - Improve/refactor the implementation of SHT_LLVM_ADDRSIG section dumping.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-addrsig.test:30
+
+## Check that llvm-readobj dumps SHT_LLVM_ADDRSIG section when --all,
+## is specified but llvm-readelf doesn't.
----------------
dumps any SHT_LLVM_ADDRSIG section


================
Comment at: test/tools/llvm-readobj/elf-addrsig.test:31
+## Check that llvm-readobj dumps SHT_LLVM_ADDRSIG section when --all,
+## is specified but llvm-readelf doesn't.
+## TODO: Refine the llvm-readelf check when GNU-style dumping be implemented.
----------------
This is a little confusing to read to me (I originally thought "--all dumps it but llvm-readelf doesn't - but llvm-readelf is not an option of llvm-readobj"). Perhaps replacing "when --all..." with "when --all is specified for LLVM style, but not for GNU style" would be better?


================
Comment at: test/tools/llvm-readobj/elf-addrsig.test:32
+## is specified but llvm-readelf doesn't.
+## TODO: Refine the llvm-readelf check when GNU-style dumping be implemented.
+
----------------
be implemented -> is implemented


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68383/new/

https://reviews.llvm.org/D68383