[PATCH] D68323: [ELF] Wrap things in `namespace lld { namespace elf {`, NFC

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 21:50:31 PDT 2019


ruiu added a comment.

Yeah, I'm fine with quoting the entire file with the namespaces, but I'm not entirely happy about adding `endian::` to read32. Looks like the problem is that we use the same name for two functions. Can you just rename one to avoid the name collision? Does that make the code look simpler?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68323/new/

https://reviews.llvm.org/D68323





More information about the llvm-commits mailing list