[PATCH] D68450: [lit] Remove setting of the target-windows feature

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 00:38:37 PDT 2019


mstorsjo created this revision.
mstorsjo added a reviewer: rnk.
Herald added a subscriber: delcypher.
Herald added a project: LLVM.

No other OSes use a target-<os> feature, and no tests (rightfully) depend on it. (This depends on D68449 <https://reviews.llvm.org/D68449> to land before.)

This is an alternative to D68135 <https://reviews.llvm.org/D68135>. (The diff is made on top of it for practical reasons.)


Repository:
  rL LLVM

https://reviews.llvm.org/D68450

Files:
  llvm/utils/lit/lit/llvm/config.py


Index: llvm/utils/lit/lit/llvm/config.py
===================================================================
--- llvm/utils/lit/lit/llvm/config.py
+++ llvm/utils/lit/lit/llvm/config.py
@@ -93,8 +93,6 @@
                         'ASAN_OPTIONS', 'detect_leaks=1', append_path=True)
             if re.match(r'^x86_64.*-linux', target_triple):
                 features.add('x86_64-linux')
-            if re.match(r'.*-windows(-[^-]+)?$', target_triple):
-                features.add('target-windows')
             if re.match(r'^i.86.*', target_triple):
                 features.add('target-x86')
             elif re.match(r'^x86_64.*', target_triple):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68450.223159.patch
Type: text/x-patch
Size: 655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191004/a09924a8/attachment.bin>


More information about the llvm-commits mailing list