[PATCH] D68418: [test] Remove locale dependency for mri-utf8.test
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 4 00:11:05 PDT 2019
thopre marked 2 inline comments as done.
thopre added inline comments.
================
Comment at: llvm/test/tools/llvm-ar/mri-utf8.test:17-18
# include arguments with non-ascii characters.
# Python on Linux defaults to ASCII encoding unless the
# environment specifies otherwise, so it is explicitly set.
+RUN: %python -c "assert open(b'\xC2\xA3.txt', 'rb').read() == b'contents\n'"
----------------
rupprecht wrote:
> This seems to be mostly describing `env LANG=en_US.UTF-8` which is now removed, so the comment can go too.
I'm not sure but I believe Ubuntu docker images for instance don't come with en_US.UTF-8 by default.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68418/new/
https://reviews.llvm.org/D68418
More information about the llvm-commits
mailing list