[PATCH] D68396: [LLD][ELF] Fix stale comment about doing ICF

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 23:49:07 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1917
 
-  // Do size optimizations: garbage collection, merging of SHF_MERGE sections
-  // and identical code folding.
+  // Do size optimizations: garbage collection and merging of SHF_MERGE
+  // sections.
----------------
`merging of SHF_MERGE ` is not correct, either. The step is performed at `      sec->finalizeInputSections();` after D67504.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68396/new/

https://reviews.llvm.org/D68396





More information about the llvm-commits mailing list