[PATCH] D55391: Don't add unnecessary compiler flags to llvm-config output

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked an inline comment as done.
tstellar added inline comments.


================
Comment at: llvm/trunk/tools/llvm-config/CMakeLists.txt:35
+# NOTE: We don't want to start extracting any random C/CXX flags that the
+# user may add that could affect the ABI.  We only want to extract flags
+# that have been added by the LLVM build system.
----------------
nik wrote:
> I guess  -D_GLIBCXX_USE_CXX11_ABI=0 would be such a flag that shouldn't be handled here?
> 
> Is there a way to have this shown up in "llvm-config --cxxflags" as in previous versions by modifying the cmake invocation? I've tried several things to get it "into" LLVM_DEFINITIONS or COMPILE_FLAGS, but my cmake foo is too limited as of now :/
Does the LLVM build system add this flag somewhere, or does the user need to add it manually when configuring?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55391/new/

https://reviews.llvm.org/D55391