[PATCH] D68135: [lit] Set the target-windows feature for mingw triples as well

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 16:50:24 PDT 2019


rnk added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:96
                 features.add('x86_64-linux')
-            if re.match(r'.*-windows-msvc$', target_triple):
+            if re.match(r'.*-windows-msvc$', target_triple) or re.match(r'.*-windows-gnu$', target_triple):
                 features.add('target-windows')
----------------
How about `-windows-[^-]*$` to handle windows-elf and the oft forgotten windows-itanium?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68135/new/

https://reviews.llvm.org/D68135





More information about the llvm-commits mailing list