[PATCH] D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 11:55:24 PDT 2019


nemanjai added a comment.

And yes, please pre-commit all the tests as NFC so we can see just the code-gen differences.



================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:465
+  /// instruction generated for ICMP_S(G|L)T
+  virtual bool isICMP_EQFoldedWithICMP_ST() const { return true; }
+
----------------
I think a more descriptive name would be:
`isEqualityCmpFoldedWithSignedCmp()`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60506/new/

https://reviews.llvm.org/D60506





More information about the llvm-commits mailing list