[PATCH] D68338: [AMDGPU] Remove dubious logic in bidirectional list scheduler

Thu Oct 3 11:44:51 PDT 2019

rampitec added a comment.

In D68338#1692785 <https://reviews.llvm.org/D68338#1692785>, @foad wrote:

> In D68338#1691536 <https://reviews.llvm.org/D68338#1691536>, @rampitec wrote:
>
> > I tend to agree with the reasoning. We can only judge after benchmarking though. You say you see more gains than loses. Can you elaborate on a magnitude of those?
>
>
> I benchmarked on gfx10 with 324 shaders from 14 different games, which I don't think I can share publically.
>  10 of them slowed down by more than 2%. The worst slow-down was 8.5%.
>  38 of them sped up by more than 2%. The best speed-up was 45%.
>
> In addition to the overall speed-up, my hope is that it will behave a bit more consistently, because it won't be able to get stuck in the odd state where a good candidate is consistently ignored.

OK, that sounds reasonable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68338/new/

https://reviews.llvm.org/D68338