[PATCH] D68374: [X86] Add v32i8 shuffle lowering strategy to recognize two v4i64 vectors truncated to v4i8 and concatenated into the lower 8 bytes with undef/zero upper bytes.

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:15542
+  // Upper bits need to be zeroable.
+  for (int i = 8; i != 24; ++i)
+    if (!Zeroable[i])
----------------
RKSimon wrote:
> Zeroable.extractBits(16, 8).isAllOnesValue() ?
That should have been 8-32. I guess I had 24 bits in my head and wrote the wrong end.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68374/new/

https://reviews.llvm.org/D68374