[PATCH] D67925: [FPEnv] Strict FP tests should use the requisite function attributes

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 09:33:47 PDT 2019


kpn updated this revision to Diff 223039.
kpn added a comment.

Based on the conclusion from D67839 <https://reviews.llvm.org/D67839>, I've updated the tests to have function attribute strictfp always be used when constrained intrinsics are used, and all function calls are also marked strictfp when the function itself is marked strictfp.

There are still three tests that aren't correct. Those will be subsequent patches.

The verifier changes are in D68233 <https://reviews.llvm.org/D68233>. It can't go in until all tests are passing with it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67925/new/

https://reviews.llvm.org/D67925

Files:
  llvm/test/CodeGen/PowerPC/fp-intrinsics-fptosi-legal.ll
  llvm/test/CodeGen/PowerPC/vector-constrained-fp-intrinsics.ll
  llvm/test/CodeGen/SystemZ/fp-strict-add-01.ll
  llvm/test/CodeGen/SystemZ/fp-strict-add-02.ll
  llvm/test/CodeGen/SystemZ/fp-strict-add-03.ll
  llvm/test/CodeGen/SystemZ/fp-strict-add-04.ll
  llvm/test/CodeGen/SystemZ/fp-strict-alias.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-01.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-02.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-03.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-04.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-09.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-10.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-11.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-12.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-14.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-15.ll
  llvm/test/CodeGen/SystemZ/fp-strict-conv-16.ll
  llvm/test/CodeGen/SystemZ/fp-strict-div-01.ll
  llvm/test/CodeGen/SystemZ/fp-strict-div-02.ll
  llvm/test/CodeGen/SystemZ/fp-strict-div-03.ll
  llvm/test/CodeGen/SystemZ/fp-strict-div-04.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-01.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-02.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-03.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-04.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-05.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-06.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-07.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-08.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-09.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-10.ll
  llvm/test/CodeGen/SystemZ/fp-strict-mul-11.ll
  llvm/test/CodeGen/SystemZ/fp-strict-round-01.ll
  llvm/test/CodeGen/SystemZ/fp-strict-round-02.ll
  llvm/test/CodeGen/SystemZ/fp-strict-round-03.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sqrt-01.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sqrt-02.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sqrt-03.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sqrt-04.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sub-01.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sub-02.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sub-03.ll
  llvm/test/CodeGen/SystemZ/fp-strict-sub-04.ll
  llvm/test/CodeGen/SystemZ/vec-strict-add-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-add-02.ll
  llvm/test/CodeGen/SystemZ/vec-strict-conv-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-conv-03.ll
  llvm/test/CodeGen/SystemZ/vec-strict-div-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-div-02.ll
  llvm/test/CodeGen/SystemZ/vec-strict-max-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-min-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-mul-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-mul-02.ll
  llvm/test/CodeGen/SystemZ/vec-strict-mul-03.ll
  llvm/test/CodeGen/SystemZ/vec-strict-mul-04.ll
  llvm/test/CodeGen/SystemZ/vec-strict-mul-05.ll
  llvm/test/CodeGen/SystemZ/vec-strict-round-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-round-02.ll
  llvm/test/CodeGen/SystemZ/vec-strict-sqrt-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-sqrt-02.ll
  llvm/test/CodeGen/SystemZ/vec-strict-sub-01.ll
  llvm/test/CodeGen/SystemZ/vec-strict-sub-02.ll
  llvm/test/CodeGen/SystemZ/vector-constrained-fp-intrinsics.ll
  llvm/test/CodeGen/X86/constrained-fp80-trunc-ext.ll
  llvm/test/CodeGen/X86/fp-intrinsics.ll
  llvm/test/CodeGen/X86/vector-constrained-fp-intrinsics-fma.ll
  llvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
  llvm/test/Feature/fp-intrinsics.ll
  llvm/test/Transforms/DCE/calls-errno.ll
  llvm/test/Transforms/InstCombine/constant-fold-libfunc.ll
  llvm/test/Transforms/InstCombine/memcpy-1.ll
  llvm/test/Verifier/fp-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67925.223039.patch
Type: text/x-patch
Size: 504973 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191003/60d15ca2/attachment-0001.bin>


More information about the llvm-commits mailing list