[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 14:04:36 PDT 2019


ychen added a comment.

In D67847#1691898 <https://reviews.llvm.org/D67847#1691898>, @jyknight wrote:

> The `abort()` function raises SIGABRT, for which the default behavior is to trigger a coredump. Do we actually want that behavior?
>
> Either `_exit()` (long available extension, which lld already uses) or `quick_exit()` (the new C standard way) seem possibly preferable?


I think this patch is more for the purpose of making error handling better than for fixing PR35547. Fixing PR35547 is probably just a side effect. Apologies that I should have updated the summary to reflect that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67847/new/

https://reviews.llvm.org/D67847





More information about the llvm-commits mailing list