[PATCH] D68396: [LLD][ELF] Fix stale comment about doing ICF

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 07:52:10 PDT 2019


russell.gallop created this revision.
russell.gallop added a reviewer: ruiu.
Herald added subscribers: MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

Fix stale comment.

ICF is now done much further down (doIcf()).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68396

Files:
  lld/ELF/Driver.cpp


Index: lld/ELF/Driver.cpp
===================================================================
--- lld/ELF/Driver.cpp
+++ lld/ELF/Driver.cpp
@@ -1914,8 +1914,7 @@
   // Replace common symbols with regular symbols.
   replaceCommonSymbols();
 
-  // Do size optimizations: garbage collection, merging of SHF_MERGE sections
-  // and identical code folding.
+  // Do size optimizations: garbage collection and merging of SHF_MERGE sections
   splitSections<ELFT>();
   markLive<ELFT>();
   demoteSharedSymbols();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68396.223019.patch
Type: text/x-patch
Size: 510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191003/9a70fa55/attachment.bin>


More information about the llvm-commits mailing list