[PATCH] D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node

Graham Hunter via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 06:52:18 PDT 2019


huntergr added a subscriber: hfinkel.
huntergr added a comment.

Hi James,

So I implemented a combine to do this, but ran into a problem -- namely that the design suggested by @hfinkel in the llvm-dev discussion (to expand to build_vector when the backend hasn't marked the splat_vector operation as supported) conflicts with the combine and ends up in an infinite loop.

For now I've guarded the combine with a check on whether the operation action has been changed from Expand for that type. Would this be acceptable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47775/new/

https://reviews.llvm.org/D47775





More information about the llvm-commits mailing list