[PATCH] D68383: [llvm-readelf/llvm-objdump] - Improve/refactor the implementation of SHT_LLVM_ADDRSIG section dumping.

Thu Oct 3 06:20:11 PDT 2019

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: test/tools/llvm-readobj/elf-addrsig.test:80
+## Check that llvm-readobj dumps SHT_LLVM_ADDRSIG section when --all is specified.
+## TODO: llvm-readelf does not dump it. Add a better test when GNU-style dumping will be implemented.
+
----------------
jhenderson wrote:
> llvm-readelf does not dump it, and should not dump it either with --all (see also the discussion about .stack_sizes dumping), so this comment should be updated to say so.
Yes. What I meant is that when it will start dumping it with `--addrsig`, it will be possible to replace `--implicit-check-not=warning --implicit-check-not=error` with something better like `--implicit-check-not=addrsig_header_blah_blah`

I'll update the comment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68383/new/

https://reviews.llvm.org/D68383