[PATCH] D68283: [ARM] Selection for MVE VMOVN

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:6918
+      return false;
+    if (M[i+1] >= 0 && M[i+1] != (int)(NumElts + i))
+      return false;
----------------
dmgreen wrote:
> samparker wrote:
> > Why the checks for M[i]>= 0?
> M[i] == -1 is "undef", so we can put whatever we want there.
Ah, ok, cheers.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:6936
+      return false;
+    if (M[i+1] >= 0 && M[i+1] != (int)(NumElts + i + 1))
+      return false;
----------------
How about refactoring these two functions? The +1 is the only difference, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68283/new/

https://reviews.llvm.org/D68283