[PATCH] D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/trunk/utils/TableGen/GlobalISel/CMakeLists.txt:5
+
+llvm_add_library(LLVMTableGenGlobalISel OBJECT
+                 CodeExpander.cpp
----------------
thakis wrote:
> Out of interest, why is this an object library instead of a normal STATIC library?
I assume you're asking because some of the bots are failing. AFAICT it's the ones with older cmakes.

I went with an object library because it doesn't need to be an actual library. It's just a means to include them in the llbm-tblgen link. Switching to a STATIC library might be how I end up fixing it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68288/new/

https://reviews.llvm.org/D68288