[PATCH] D68351: [profile] Add a mode to continuously sync counter updates to a file
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 2 16:55:36 PDT 2019
vsk marked an inline comment as done.
vsk added inline comments.
================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:396
+ int Length = getCurFilenameLength();
+ char *FilenameBuf = (char *)COMPILER_RT_ALLOCA(Length + 1);
+ const char *Filename = getCurFilename(FilenameBuf, 0);
----------------
ejvaughan wrote:
> Does `FilenameBuf` need to be free'd, or is it stack allocated?
It's backed by a call to `__builtin_alloca`, which should just be a simple stack allocation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68351/new/
https://reviews.llvm.org/D68351
More information about the llvm-commits
mailing list