[PATCH] D68313: [compiler-rt] Use GetNextInstructionPc in signal handlers

Wed Oct 2 11:01:02 PDT 2019

vitalybuka marked an inline comment as done.
vitalybuka added inline comments.

================
Comment at: compiler-rt/test/sanitizer_common/TestCases/Linux/signal_line.cpp:9
+
+// FIXME: seems to fail on ARM
+// REQUIRES: x86_64-target-arch
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > eugenis wrote:
> > > Well, this is not a good symptom.
> > > Do you know why?
> > That's a copy/paste from similar test.
> > I'd like to land this one, if it's green the to try to land a patch removing this lines, for easier reverting
> from sanitizer_common/TestCases/Linux/ill.cpp
hm, probably safer to keep all platforms
at least we will know where it does not work ASAP
done

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68313/new/

https://reviews.llvm.org/D68313