[PATCH] D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0
Dávid Bolvanský via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 2 10:09:46 PDT 2019
- Previous message: [PATCH] D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0
- Next message: [PATCH] D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
xbolva00 marked an inline comment as done.
xbolva00 added inline comments.
================
Comment at: test/Transforms/InstCombine/snprintf-memccpy.ll:47
+; CHECK-NO-MEMCCPY-LABEL: @test_string_to_buf_retval_known_nonzero_n(
+; CHECK-NO-MEMCCPY-NEXT: [[SIZE:%.*]] = shl i64 3, [[N:%.*]]
+; CHECK-NO-MEMCCPY-NEXT: [[TMP1:%.*]] = sub i64 [[SIZE]], 1
----------------
hmm...
Should I call DecSize->eraseFromParent() ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67986/new/
https://reviews.llvm.org/D67986
- Previous message: [PATCH] D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0
- Next message: [PATCH] D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the llvm-commits
mailing list