[PATCH] D68334: [yaml2obj] - Add a Size tag support for SHT_LLVM_ADDRSIG sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 08:22:47 PDT 2019


jhenderson added a comment.

One suggestion. Otherwise, looks good.



================
Comment at: test/tools/yaml2obj/elf-llvm-addrsig-section.yaml:237
+
+## Check we can use "Size" and "Content" together to create a SHT_LLVM_ADDRSIG section.
+
----------------
Thinking about it, there probably wants to be a test-case for Size == Content, to show that this exact scenario is also allowed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68334/new/

https://reviews.llvm.org/D68334





More information about the llvm-commits mailing list