[PATCH] D68323: [ELF] Wrap things in `namespace lld { namespace elf {`, NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 02:19:02 PDT 2019


MaskRay added a comment.

In D68323#1690943 <https://reviews.llvm.org/D68323#1690943>, @ruiu wrote:

> I think that somewhere in the Coding Style Guideline, it is recommended to keep `namespace {}` as narrow as possible. This is why I chose this style in the first place. Has that changed?


I don't know the history but https://llvm.org/docs/CodingStandards.html#id56 gives an example that does this:

  namespace llvm {
  namespace knowledge {
  ...


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68323/new/

https://reviews.llvm.org/D68323





More information about the llvm-commits mailing list