[PATCH] D68323: [ELF] Wrap things in `namespace lld { namespace elf {`, NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 01:15:13 PDT 2019


MaskRay created this revision.
Herald added subscribers: llvm-commits, pzheng, s.egerton, lenary, Jim, jsji, jocewei, PkmX, dexonsmith, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar, asb, fedor.sergeev, kbarton, hiraditya, arichardson, nhaehnle, jvesely, nemanjai, sdardis, emaste, dylanmckay, jyknight, srhines.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This makes it clear ELF/**/*.cpp files define things in the lld::elf
namespace and simplifies `elf::foo` to `foo`.

Due to the rule of unqualified name lookup, calls to write{16,32} and
read{16,32} in Arch/Mips.cpp can be ambiguous. Change `using
llvm::support::endian` to a namespace alias and qualify the functions to
disambiguate.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D68323

Files:
  ELF/Arch/AArch64.cpp
  ELF/Arch/AMDGPU.cpp
  ELF/Arch/ARM.cpp
  ELF/Arch/AVR.cpp
  ELF/Arch/Hexagon.cpp
  ELF/Arch/MSP430.cpp
  ELF/Arch/Mips.cpp
  ELF/Arch/MipsArchTree.cpp
  ELF/Arch/PPC.cpp
  ELF/Arch/PPC64.cpp
  ELF/Arch/RISCV.cpp
  ELF/Arch/SPARCV9.cpp
  ELF/Arch/X86.cpp
  ELF/Arch/X86_64.cpp
  ELF/CallGraphSort.cpp
  ELF/DWARF.cpp
  ELF/Driver.cpp
  ELF/DriverUtils.cpp
  ELF/EhFrame.cpp
  ELF/ICF.cpp
  ELF/InputFiles.cpp
  ELF/InputFiles.h
  ELF/InputSection.cpp
  ELF/LTO.cpp
  ELF/LinkerScript.cpp
  ELF/MapFile.cpp
  ELF/MarkLive.cpp
  ELF/OutputSections.cpp
  ELF/Relocations.cpp
  ELF/ScriptLexer.cpp
  ELF/ScriptParser.cpp
  ELF/SymbolTable.cpp
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/SyntheticSections.cpp
  ELF/Target.cpp
  ELF/Target.h
  ELF/Thunks.cpp
  ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68323.222767.patch
Type: text/x-patch
Size: 69452 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191002/6fa74d57/attachment-0001.bin>


More information about the llvm-commits mailing list