[PATCH] D66526: [utils] Add the llvm-locstats tool

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: llvm/trunk/utils/llvm-locstats/llvm-locstats.py:107-109
+  # Get the directory of the LLVM tools.
+  llvm_dwarfdump_cmd = os.path.join(os.path.dirname(__file__), \
+                                    "llvm-dwarfdump")
----------------
rupprecht wrote:
> This assumes that `llvm-dwarfdump` exists in the same directory as `llvm-locstats`, which may not be true, e.g. for build systems that build dwardump and locstats in separate build trees. Can this be configurable? Possibly a regular `$PATH` lookup makes sense here (with cwd as a preferred location), although allowing a flag pointing to the location of dwarfdump would be the most flexible.
(Note: feel free to reland this bit as-is, I can suggest this in the form of a patch once this landing has stuck).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66526/new/

https://reviews.llvm.org/D66526