[PATCH] D68283: [ARM] Selection for MVE VMOVN

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 08:00:45 PDT 2019


dmgreen marked an inline comment as done.
dmgreen added a comment.

There might be something wrong with this. A test I just ran failed in a way I don't understand yet. Give me a minute to figure out what's up.



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:6918
+      return false;
+    if (M[i+1] >= 0 && M[i+1] != (int)(NumElts + i))
+      return false;
----------------
samparker wrote:
> Why the checks for M[i]>= 0?
M[i] == -1 is "undef", so we can put whatever we want there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68283/new/

https://reviews.llvm.org/D68283





More information about the llvm-commits mailing list