[PATCH] D68033: [llvm-ar] Make paths case insensitive when on windows

[Edd Dawson via Phabricator via llvm-commits]

edd added a comment.

NTFS and the layers above it don't normalize filenames (in the Unicode sense) and I believe that path names are stored as sequences of 16bit integers, without any guarantee of being well-formed UCS-2/UTF_16. So I don't think that a comparison via locale-aware case folding would be correct for paths. I don't have sources for this, it's just what I recall from having done experiments some time ago.

Use of CompareStringOrdinal() <https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-comparestringordinal> is suggested by https://docs.microsoft.com/en-us/windows/win32/intl/handling-sorting-in-your-applications


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68033/new/

https://reviews.llvm.org/D68033