[PATCH] D68033: [llvm-ar] Make paths case insensitive when on windows

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:492
+  if (Triple(sys::getProcessTriple()).isOSWindows())
+    llvm::transform(NormalizedPath, NormalizedPath.begin(), ::toupper);
+
----------------
ruiu wrote:
> This is perhaps my personal preference, but I prefer making it lowercase rather than uppercase when normalizing.
This may need to use POSIX/C locale llvm::toUpper from llvm/ADT/StringExtras.h if my reading of binutils source is correct. A manual test that involves non-ASCII Unicode is needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68033/new/

https://reviews.llvm.org/D68033