[PATCH] D68062: Propeller lld framework for basicblock sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Propeller.h:195
+
+  ~Propfile() {}
+
----------------
Please remove empty dtors from here and other classes.


================
Comment at: lld/include/lld/Common/PropellerCommon.h:13
+
+using std::string;
+
----------------
Importing from `std` is not allowed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68062/new/

https://reviews.llvm.org/D68062