[PATCH] D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/utils/update_cc_test_checks.py:136
   else:
     print('The clang command line should include -emit-llvm as asm tests '
           'are discouraged in Clang testsuite.', file=sys.stderr)
----------------
greened wrote:
> MaskRay wrote:
> > The comment is here because there was petty strong objection to have .cc->.s tests checked in in the repository. For end-to-end tests that are personal uses, I think it is fine. If you want to extend that, you'll have to seek for more opinions.
> I'm not sure what you're saying.  Are you saying this is ok to go in as long as upstream tests don't use it without permissions or that this change itself needs more reviewers?  If the latter, do you have suggestions?  You and Dávid are the only people who have worked on this script so I wasn't sure who else to include.
> 
I don't have good suggestions right now but you can probably raise the topic on the mailing list about end-to-end tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68230/new/

https://reviews.llvm.org/D68230