[PATCH] D68204: [llvm-lib] Correctly handle .lib input files

Tue Oct 1 22:07:07 PDT 2019

ruiu marked an inline comment as done.
ruiu added inline comments.

================
Comment at: llvm/test/tools/llvm-lib/nest.test:12
+RUN: llvm-lib -out:%t/bar.lib %t/foo.lib %t/bar.o
+
+RUN: llvm-ar t %t/bar.lib | FileCheck %s
----------------
MaskRay wrote:
> What if `%t/foo.lib` is specified twice? It may worth a test.
Good point. Looks like llvm-ar doesn't work correctly for duplicated command line arguments. If you specify the same file more than once, only the first occurrence of the file is recognized and the remaining arguments are ignored. We need to implement that behavior.

Since that's not a new bug, I'll address that in another patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68204/new/

https://reviews.llvm.org/D68204