[PATCH] D68159: [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary

Tue Oct 1 17:56:10 PDT 2019

hiraditya accepted this revision.
hiraditya added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lib/LTO/LTO.cpp:1335
            ExportedGUIDs.count(GUID);
   };
+
----------------
tejohnson wrote:
> hiraditya wrote:
> > Maybe we could make this a separate function, it seems we are using similar checks in llvm/lib/LTO/ThinLTOCodeGenerator.cpp:528, 
> Do you mean the isExported lambda (ThinLTOCodeGenerator.cpp:528 is unrelated code at HEAD)? We use a call back in part because the different LTO APIs handle exported symbols differently. The ExportedGUIDs set here in the new API is set up differently than the GUIDPreservedSymbols in the old API. Also, the old LTO API doesn't currently do WPD.
oh sorry, i was referring to: https://github.com/llvm-mirror/llvm/blob/master/lib/LTO/ThinLTOCodeGenerator.cpp#L586. But i understood the point.  thanks!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68159/new/

https://reviews.llvm.org/D68159