[PATCH] D68139: [Support, ARM64] Define getHostCPUFeatures for Windows on ARM64 platform

Tom Tan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 17:46:13 PDT 2019


TomTan added inline comments.


================
Comment at: lib/Support/Host.cpp:1515
 }
+#elif defined(_WIN32) && defined(__aarch64__)
+bool sys::getHostCPUFeatures(StringMap<bool> &Features) {
----------------
mstorsjo wrote:
> This should be `defined(_WIN32) && (defined(__aarch64__) || defined(_M_ARM64))`, otherwise it won't be used by MSVC.
> 
> Also, those PF_* constants are missing in mingw-w64; I'll have to add them there in order not to break builds with such headers.
As Win32 API is called here, a single check on `_M_ARM64` would be enough for clang and MSVC, but I am not sure for mingw-w64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68139/new/

https://reviews.llvm.org/D68139





More information about the llvm-commits mailing list