[PATCH] D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability

Tue Oct 1 14:42:40 PDT 2019

rupprecht marked 2 inline comments as done.
rupprecht added a comment.

In D68066#1687776 <https://reviews.llvm.org/D68066#1687776>, @jhenderson wrote:

> In D68066#1687377 <https://reviews.llvm.org/D68066#1687377>, @justice_adams wrote:
>
> > @rupprecht A bit of a beginner to LLVM, but why add the suppression for DynamicRelocations when `--disassemble`  is provided?
>
>
> The LLVM binutils, like llvm-objdump, aim to produce output identical to the equivalent GNU binutils (with some exceptions for various specific reasons). This change aims to improve that compatibility. It could be argued however, that the dynamic relocations change should be put in a separate change, since it's a slightly different issue.

Good point, I split that off to D68303 <https://reviews.llvm.org/D68303>. Will remove it from this revision and address the other points shortly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68066/new/

https://reviews.llvm.org/D68066