[PATCH] D68177: compiler-rt: move all __GLIBC_PREREQ into own header file

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka marked an inline comment as done.
vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_glibc_version.h:20
+#include <features.h>
+#endif
+
----------------
ro wrote:
> That's exactly the change I've successfully tested on both
> `amd64-pc-solaris2.11` and `sparcv9-sun-solaris2.11`
> earlier today.
This should be this way from begining.
I was confused by __GLIBC_PREREQ sanitizer_linux_libcdep.cpp under
#if SANITIZER_FREEBSD || SANITIZER_LINUX || SANITIZER_NETBSD ||               
    SANITIZER_OPENBSD || SANITIZER_SOLARIS

but solaris, probably intentionally, was covered by #ifndef __GLIBC_PREREQ check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68177/new/

https://reviews.llvm.org/D68177