[PATCH] D68287: [ASan] Make GlobalsMD member a const reference

[Leonard Chan via Phabricator via llvm-commits]

leonardchan marked 2 inline comments as done.
leonardchan added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:695
   Value *LocalDynamicShadow = nullptr;
-  GlobalsMetadata GlobalsMD;
+  const GlobalsMetadata &GlobalsMD;
   DenseMap<const AllocaInst *, bool> ProcessedAllocas;
----------------
vitalybuka wrote:
> please add const into constructor
> ModuleAddressSanitizer(Module &M, const GlobalsMetadata &GlobalsMD,
> 
> maybe also pointer, so you can't pass temp object
> ModuleAddressSanitizer(Module &M, const GlobalsMetadata *GlobalsMD,
> 
> 
Woops. Sorry, I committed after I got the LGTM but didn't see your comments until later. I committed r373391 which addresses these comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68287/new/

https://reviews.llvm.org/D68287