[PATCH] D68287: [ASan] Make GlobalsMD member a const reference

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:695
   Value *LocalDynamicShadow = nullptr;
-  GlobalsMetadata GlobalsMD;
+  const GlobalsMetadata &GlobalsMD;
   DenseMap<const AllocaInst *, bool> ProcessedAllocas;
----------------
please add const into constructor
ModuleAddressSanitizer(Module &M, const GlobalsMetadata &GlobalsMD,

maybe also pointer, so you can't pass temp object
ModuleAddressSanitizer(Module &M, const GlobalsMetadata *GlobalsMD,




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68287/new/

https://reviews.llvm.org/D68287