[PATCH] D68265: [InstCombine] Simplify fma multiplication to nan for undef or nan operands.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4612
   if (FMF.noNaNs() && FMF.noSignedZeros() && match(Op0, m_AnyZeroFP()))
     return ConstantFP::getNullValue(Op1->getType());
 
----------------
cameron.mcinally wrote:
> Side note: these 2 transforms are not correct for X=Inf. I believe that they should return a QNaN in that case.
Yep thanks, I think we are missing `FMF.noInfs`, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68265/new/

https://reviews.llvm.org/D68265