[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.
Daniel Sanders via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 1 11:39:22 PDT 2019
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/include/llvm/ADT/Statistic.h:47
-class Statistic {
+class StatisticBase {
public:
----------------
Do we actually need the common base class? I'm thinking that since NoopStatistic never registers (and can't because the interfaces to do so changed to TrackingStatistic*), then there's a good chance that nothing reads DebugType, Name, Desc, Value, Initialized and we might be able to save a little memory by eliminating them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68252/new/
https://reviews.llvm.org/D68252
More information about the llvm-commits
mailing list