[PATCH] D68086: [llvm-readelf] - Report a warning when .hash section contains a chain with a cycle.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 06:02:01 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: test/tools/llvm-readobj/elf-hash-symbols.test:393
+## p_offset + (p_vaddr - DT_HASH) = p_offset + (0 - 0) = p_offset,
+## which is the start of PT_LOAD, i.e. the file offset of .hash
+      - Tag:   DT_HASH
----------------
Nit: missing trailing full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68086/new/

https://reviews.llvm.org/D68086





More information about the llvm-commits mailing list