[PATCH] D67345: [InstCombine] Allow values with multiple users in SimplifyDemandedVectorElts

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 05:05:15 PDT 2019


piotr added a comment.

In D67345#1688379 <https://reviews.llvm.org/D67345#1688379>, @nhaehnle wrote:

> This is a useful change, but there is an unfortunate asymmetry here in how the code is structured: in addition to `extractelement`, we could also have `shufflevector` users (or masked stores etc.). Presumably we'd be able to handle all of those together without duplicating the code. Is there a way to take this into account?
>
> Also, two comments inline.


Good point, I will try extending the patch to also handle shufflevector.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67345/new/

https://reviews.llvm.org/D67345





More information about the llvm-commits mailing list