[PATCH] D68085: [yaml2obj/obj2yaml] - Add support for SHT_HASH sections.

[George Rimar via llvm-commits]

Hi David,

The issue was fixed in r373319 (https://reviews.llvm.org/rL373319)

Best regards,
George | Developer | Access Softek, Inc

________________________________________
От: David Zarzycki via Phabricator <reviews at reviews.llvm.org>
Отправлено: 1 октября 2019 г. 13:56
Кому: George Rimar; jh7370 at my.bristol.ac.uk; maskray at google.com
Копия: dave at znu.io; rupprecht at google.com; nuta at seiya.me; Igor Kudrin; Evgeny Leviant; llvm-commits at lists.llvm.org
Тема: [PATCH] D68085: [yaml2obj/obj2yaml] - Add support for SHT_HASH sections.

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.  If you suspect potential phishing or spam email, report it to ReportSpam at accesssoftek.com

davezarzycki added a comment.

What platform was this tested on? This seems to be failing on my Fedora 31 x86_64 box:

  FAIL: LLVM :: tools/obj2yaml/elf-hash-section.yaml (49646 of 58398)
  ******************** TEST 'LLVM :: tools/obj2yaml/elf-hash-section.yaml' FAILED ********************
  Script:
  --
  : 'RUN: at line 7';   /tmp/_update_lc/t/bin/yaml2obj --docnum=1 /home/dave/s/lp/llvm/test/tools/obj2yaml/elf-hash-section.yaml -o /tmp/_update_lc/t/test/tools/obj2yaml/Output/elf-hash-section.yaml.tmp1
  : 'RUN: at line 8';   /tmp/_update_lc/t/bin/obj2yaml /tmp/_update_lc/t/test/tools/obj2yaml/Output/elf-hash-section.yaml.tmp1 | /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/llvm/test/tools/obj2yaml/elf-hash-section.yaml --check-prefix=CHAIN-BUCKET
  : 'RUN: at line 38';   /tmp/_update_lc/t/bin/yaml2obj --docnum=2 /home/dave/s/lp/llvm/test/tools/obj2yaml/elf-hash-section.yaml -o /tmp/_update_lc/t/test/tools/obj2yaml/Output/elf-hash-section.yaml.tmp2
  : 'RUN: at line 39';   /tmp/_update_lc/t/bin/obj2yaml /tmp/_update_lc/t/test/tools/obj2yaml/Output/elf-hash-section.yaml.tmp2 | /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/llvm/test/tools/obj2yaml/elf-hash-section.yaml --check-prefix=CONTENT
  --
  Exit Code: 2

  Command Output (stderr):
  --
  Program aborted due to an unhandled Error:
  Error value was Success. (Note: Success values must still be checked prior to being destroyed).
  Stack dump:
  0.    Program arguments: /tmp/_update_lc/t/bin/obj2yaml /tmp/_update_lc/t/test/tools/obj2yaml/Output/elf-hash-section.yaml.tmp2
   #0 0x000000000079e77f llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/tmp/_update_lc/t/bin/obj2yaml+0x79e77f)
   #1 0x000000000079cd28 llvm::sys::RunSignalHandlers() (/tmp/_update_lc/t/bin/obj2yaml+0x79cd28)
   #2 0x000000000079ed41 SignalHandler(int) (/tmp/_update_lc/t/bin/obj2yaml+0x79ed41)
   #3 0x00007ffff7fa8b20 __restore_rt (/lib64/libpthread.so.0+0x14b20)
   #4 0x00007ffff618a625 raise (/lib64/libc.so.6+0x3c625)
   #5 0x00007ffff61738d9 abort (/lib64/libc.so.6+0x258d9)
   #6 0x0000000000766c56 llvm::Error::fatalUncheckedError() const (/tmp/_update_lc/t/bin/obj2yaml+0x766c56)
   #7 0x00000000005bfcaf (anonymous namespace)::ELFDumper<llvm::object::ELFType<(llvm::support::endianness)1, false> >::dump() (/tmp/_update_lc/t/bin/obj2yaml+0x5bfcaf)
   #8 0x00000000005b9e54 elf2yaml(llvm::raw_ostream&, llvm::object::ObjectFile const&) (/tmp/_update_lc/t/bin/obj2yaml+0x5b9e54)
   #9 0x00000000005b00a3 main (/tmp/_update_lc/t/bin/obj2yaml+0x5b00a3)
  #10 0x00007ffff61751a3 __libc_start_main (/lib64/libc.so.6+0x271a3)
  #11 0x00000000005aface _start (/tmp/_update_lc/t/bin/obj2yaml+0x5aface)
  FileCheck error: '-' is empty.
  FileCheck command line:  /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/llvm/test/tools/obj2yaml/elf-hash-section.yaml --check-prefix=CONTENT

  --

  ********************
  Testing Time: 110.38s
  ********************
  Failing Tests (1):
      LLVM :: tools/obj2yaml/elf-hash-section.yaml

    Expected Passes    : 42883
    Expected Failures  : 100
    Unsupported Tests  : 15414
    Unexpected Failures: 1


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68085/new/

https://reviews.llvm.org/D68085