[llvm] r373321 - ConstantFold - ConstantFoldSelectInstruction - assume constant vector elements are constant. NFCI.
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 1 03:22:01 PDT 2019
Author: rksimon
Date: Tue Oct 1 03:22:01 2019
New Revision: 373321
URL: http://llvm.org/viewvc/llvm-project?rev=373321&view=rev
Log:
ConstantFold - ConstantFoldSelectInstruction - assume constant vector elements are constant. NFCI.
Goes a bit further than rL372743 which added the early out - elements should be Constant so use cast<Constant> instead (and rely on the assert if anything fails).
Modified:
llvm/trunk/lib/IR/ConstantFold.cpp
Modified: llvm/trunk/lib/IR/ConstantFold.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/ConstantFold.cpp?rev=373321&r1=373320&r2=373321&view=diff
==============================================================================
--- llvm/trunk/lib/IR/ConstantFold.cpp (original)
+++ llvm/trunk/lib/IR/ConstantFold.cpp Tue Oct 1 03:22:01 2019
@@ -746,8 +746,7 @@ Constant *llvm::ConstantFoldSelectInstru
ConstantInt::get(Ty, i));
Constant *V2Element = ConstantExpr::getExtractElement(V2,
ConstantInt::get(Ty, i));
- Constant *Cond = dyn_cast<Constant>(CondV->getOperand(i));
- if (!Cond) break;
+ auto *Cond = cast<Constant>(CondV->getOperand(i));
if (V1Element == V2Element) {
V = V1Element;
} else if (isa<UndefValue>(Cond)) {
More information about the llvm-commits
mailing list