[PATCH] D68131: Switch lowering: omit range check for bit tests when default is unreachable (PR43129)

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 02:20:38 PDT 2019


hans marked an inline comment as done.
hans added inline comments.


================
Comment at: llvm/test/CodeGen/X86/switch-bt.ll:165
 ; CHECK-LABEL: test5
-; CHECK: cmpl $8, %edi
-; CHECK: ja
+; CHECK-NOT: cmp
 
----------------
xbolva00 wrote:
> Can you  (re)generate CHECKs with update_llc_test_checks.py?
Why? It's a hand-written test, and the point of the patch is specifically to omit the cmp here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68131/new/

https://reviews.llvm.org/D68131





More information about the llvm-commits mailing list