[PATCH] D68256: ELF: Add .interp synthetic sections first in createSyntheticSections().

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 01:56:20 PDT 2019


grimar accepted this revision.
grimar added a comment.

LGTM with a minor nit.



================
Comment at: lld/test/ELF/dynamic-linker.s:10
 # RUN: ld.lld --dynamic-linker=foo %t.o %t.so -o %t
-# RUN: llvm-readelf -program-headers %t | FileCheck %s
+# RUN: llvm-readelf -program-headers -section-headers %t | FileCheck %s
 
----------------
Perhaps a bit better would be to use `FileCheck %s --implicit-check-not=.bss` here and above.
That removes a dependency on the order of program/sections headers printed (recently there were patches that changed the output order back and forth to be more GNU-output compatible).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68256/new/

https://reviews.llvm.org/D68256





More information about the llvm-commits mailing list