[PATCH] D68254: [WebAssembly] Error when using wasm64 for ISel

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 00:22:37 PDT 2019


aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp:60
+    if (Subtarget->hasAddr64())
+      report_fatal_error("64-bit WebAssembly (wasm64) is not supported");
+
----------------
How about 'not currently supported'? I don't want to make an impression that this is something that's meant not to be supported but also don't want to imply that we have plans to support that in the future, so... 🤷🏻‍♀️


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68254/new/

https://reviews.llvm.org/D68254





More information about the llvm-commits mailing list