[PATCH] D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 30 18:50:03 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/utils/update_cc_test_checks.py:136
else:
print('The clang command line should include -emit-llvm as asm tests '
'are discouraged in Clang testsuite.', file=sys.stderr)
----------------
The comment is here because there was petty strong objection to have .cc->.s tests checked in in the repository. For end-to-end tests that are personal uses, I think it is fine. If you want to extend that, you'll have to seek for more opinions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68230/new/
https://reviews.llvm.org/D68230
More information about the llvm-commits
mailing list