[PATCH] D68131: Switch lowering: omit range check for bit tests when default is unreachable (PR43129)

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 14:33:23 PDT 2019


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2674
+    if (MBB != NextBlock(SwitchBB))
+      Root = DAG.getNode(ISD::BR, dl, MVT::Other, Root, DAG.getBasicBlock(MBB));
+  }
----------------
This statement and conditional matches L2667.  I think we could flip the conditionals/check for this first? DRY


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68131/new/

https://reviews.llvm.org/D68131





More information about the llvm-commits mailing list