[PATCH] D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic

[Vedant Kumar via Phabricator via llvm-commits]

vsk requested changes to this revision.
vsk added a comment.
This revision now requires changes to proceed.

Thanks for working on this!



================
Comment at: llvm/include/llvm/Transforms/Utils/CodeExtractor.h:117
     /// determine whether it is eligible for extraction.
     bool isEligible() const { return !Blocks.empty(); }
 
----------------
The validation done by `validateInputDataDependencies` should be moved into `isEligible`. This way, `extractCodeRegion` will simply fail on non-eligible regions -- this is something clients of CodeExtractor can already handle.

Adding a new validation API may leave some clients, like PartialInliner, unfixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68192/new/

https://reviews.llvm.org/D68192