[PATCH] D67574: AMDGPU: Fix an out of date assert in addressing FrameIndex

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 12:48:58 PDT 2019


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/stack-pointer-offset-relative-frameindex.ll:45
+  call void @svm_eval_nodes(float addrspace(5)* %kg, <1339 x i32> addrspace(5)* %sd, <4 x i32> addrspace(5)* %state, i32 0, i32 4194304)
+  br i1 undef, label %shader_eval_surface.exit, label %if.then4.i
+
----------------
Probably should make this defined


================
Comment at: test/CodeGen/AMDGPU/stack-pointer-offset-relative-frameindex.ll:57
+  store i32 %add.i.i.i.i, i32 addrspace(5)* undef, align 16
+  unreachable
+
----------------
Probably should not use unreachable


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67574/new/

https://reviews.llvm.org/D67574





More information about the llvm-commits mailing list