[PATCH] D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM, with two nitpicks inline.



================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:254-255
+  switch (Opc) {
+  default:
+    return 0;
+  case AMDGPU::S_BUFFER_LOAD_DWORD_IMM:
----------------
Move the default branch to the end for readability? (I realize that's what the original code looks like...)


================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:298-299
+  switch (Opc) {
+  default:
+    return UNKNOWN;
+  case AMDGPU::S_BUFFER_LOAD_DWORD_IMM:
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65496/new/

https://reviews.llvm.org/D65496